Fixed things found in session 1 of the grand Python review.#59
Merged
Fixed things found in session 1 of the grand Python review.#59
Conversation
- Added a note that Confs as been renamed to Configurations in CHANGELOG.md. - Entity.refresh no longer tries to interpret HTTPErrors, and just lets them bubble up. Fixed test_delete tests in test_input, test_role, test_saved_search, and test_user to expect HTTPError instead of EntityDeletedException. Deleted EntityDeletedException since it is not longer used. - Fixed namespace logic in Entity._proper_namespace to draw on the entity's own namespace before the service's namespace. - Moved AmbiguousReferenceException throwing from _load_state in Entity to _load_atom_entry (where it should be). - Fixed doctoring of Service.search to indicate that it returns a Job, not the results of a oneshot search. - Edited a comment that was too Freddian for public consumption. - Moved URL-unquoting of links from refresh to read on Entity, and made it a UrlEncoded step instead of unencoding them.
Contributor
There was a problem hiding this comment.
Not English. :) Should be something like:
"The jobs endpoint only returns an outermost element, instead of an outermost element with an element embedded inside."
Contributor
|
Changes look good, modulo comments. Prior to merge, let's have Brad take a look. Also, I'd like us to write some tests for the namespace thing, I don't know if we have any that specifically test that, but we should if we don't. |
Author
|
Added some tests on the namespace thing. |
Author
|
Going to have a bunch more. We can have Brad look at the whole mess. |
madhadron
pushed a commit
that referenced
this pull request
Nov 30, 2012
Fixed things found in session 1 of the grand Python review.
mateusz834
pushed a commit
that referenced
this pull request
Apr 15, 2026
* Add ai_custom_alert_app * Disable app by default * PR fixes #1 * PR fixes * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_role, test_saved_search, and test_user to expect HTTPError instead of EntityDeletedException. Deleted EntityDeletedException
since it is not longer used.