Skip to content

Addition of basic auth support#132

Closed
matthewsullivan-wf wants to merge 5 commits intosplunk:developfrom
sullivanmatt:basic_auth
Closed

Addition of basic auth support#132
matthewsullivan-wf wants to merge 5 commits intosplunk:developfrom
sullivanmatt:basic_auth

Conversation

@matthewsullivan-wf
Copy link
Copy Markdown

@matthewsullivan-wf matthewsullivan-wf commented Dec 23, 2015

Following the pattern defined in splunk/splunk-sdk-ruby#43, I have implemented Basic Auth in this PR.

from splunklib.client import Service

service = Service(host="splunk.myhost.net", port=8089, scheme="https", version=6.3,
                  basic=True, username="steve", password="puppydoge")

service.indexes['test'].submit("My message!", host="localhost", sourcetype="text")

@matthewsullivan-wf
Copy link
Copy Markdown
Author

matthewsullivan-wf commented Dec 23, 2015

@itay any idea what I'm doing wrong getting this test set up?
https://travis-ci.org/splunk/splunk-sdk-python/jobs/98574591#L602

@matthewsullivan-wf
Copy link
Copy Markdown
Author

matthewsullivan-wf commented Jan 18, 2016

@itay ^

@itay
Copy link
Copy Markdown
Contributor

itay commented Jan 29, 2016

Hey @matthewsullivan-wf - sorry it took so long to reply. I finally had some time to look today.

Anyway, I found the issue with your test. I put a comment on the specific line, but I wanted to ask you how you wanted to proceed. I can merge your PR once that's fixed (and if you want to rebase it to the tip of develop and squash your commits), or I can just fix it and get that merged. I wanted to give you the option of doing it yourself so you get "credit" for the contribution on GitHub, since you did the hard work :)

Let me know how you want to proceed.

itay
itay reviewed Jan 29, 2016
View reviewed changes
Comment thread tests/test_binding.py
Copy link
Copy Markdown
Contributor

@itay itay Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're trying to log in with a bad set of credentials. Change this line to:

        opts["username"] = self.opts.kwargs["username"]
        opts["password"] = self.opts.kwargs["password"]

@sullivanmatt
Copy link
Copy Markdown
Contributor

sullivanmatt commented Jan 29, 2016

@itay appreciate the consideration for credit, but I don't care - I just need it fixed so we can start using the SDK at my place of work :) Go ahead if you've got everything staged that you need.

@itay itay mentioned this pull request Jan 29, 2016
Merged
@itay
Copy link
Copy Markdown
Contributor

itay commented Jan 29, 2016

Superceded by #133

@itay itay closed this Jan 29, 2016
mateusz834 pushed a commit that referenced this pull request Apr 15, 2026
@Ickerday
Test concurrency groups in the test pipeline (#132)
fd70297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewsullivan-wf @itay @sullivanmatt