Remove Sphinx as a required dependency#15
Merged
AA-Turner merged 6 commits intosphinx-doc:masterfrom Jan 13, 2024
Merged
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
0032624 to
32d5a29
Compare
3415bc0 to
b8dc42f
Compare
|
Gentle reminder to get this in. We are also hampered by the circular dependency (using pipdeptree). |
AA-Turner
reviewed
Jan 13, 2024
AA-Turner
reviewed
Jan 13, 2024
AA-Turner
reviewed
Jan 13, 2024
AA-Turner
reviewed
Jan 13, 2024
AA-Turner
added a commit
that referenced
this pull request
Jan 13, 2024
Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
@AA-Turner Please revert, the dep is needed, it has broken our CIs: |
Member
|
You're using Sphinx v4.5.0, which is no longer supported -- if you require Sphinx 4 still, you'll have to pin dependencies. A |
|
@AA-Turner let's do a Sphinx 4.5.1 patch release then fix with https://github.com/sphinx-doc/sphinx/blob/v4.5.0/setup.py#L17 line changed to: - 'sphinxcontrib-applehelp',
+ 'sphinxcontrib-applehelp<=1.0.4',in 5.x, 6.x, 7.x this needs to be done too to prevent simillar issue in the future |
astrsh
added a commit
to PolyhedralDev/TerraDocs
that referenced
this pull request
Feb 12, 2024
CI got broken as the sphinxcontrib.applehelp extension was changed to require Sphinx version 5.0.0+ in patch bump here: sphinx-doc/sphinxcontrib-applehelp#15 Dependencies have been bumped to fix this. This slightly changes some styling, file name styling in code block captions is a little broken, will need to fix later. Did not do much in-depth investigation if anything else is broken, but skimmed through most pages and they look fine.
github-actions Bot
pushed a commit
to PolyhedralDev/TerraDocs
that referenced
this pull request
Feb 12, 2024
CI got broken as the sphinxcontrib.applehelp extension was changed to require Sphinx version 5.0.0+ in patch bump here: sphinx-doc/sphinxcontrib-applehelp#15 Dependencies have been bumped to fix this. This slightly changes some styling, file name styling in code block captions is a little broken, will need to fix later. Did not do much in-depth investigation if anything else is broken, but skimmed through most pages and they look fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.