Repository navigation
ksponspeech remove - #3013
Merged
Merged
ksponspeech remove#3013
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the KsponSpeech recipe and all associated files from the SpeechBrain repository. The removal is motivated by accessibility issues - the dataset is not available to non-Korean citizens, making it nearly impossible to maintain actively. This cleanup will help streamline the codebase by removing unmaintainable recipes.
Key Changes
- Complete removal of the KsponSpeech recipe directory including ASR, LM, and Tokenizer subdirectories
- Removal of test configuration for KsponSpeech
- Updates to main documentation files (README.md and PERFORMANCE.md) to remove KsponSpeech references
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/recipes/KsponSpeech.csv | Removes test configuration entries for KsponSpeech ASR, LM, and Tokenizer tasks |
| recipes/KsponSpeech/unzip_ksponspeech.sh | Removes utility script for extracting KsponSpeech dataset |
| recipes/KsponSpeech/ksponspeech_prepare.py | Removes data preparation script with normalization and CSV generation logic |
| recipes/KsponSpeech/convert_to_wav.py | Removes utility for converting PCM files to WAV format |
| recipes/KsponSpeech/Tokenizer/train.py | Removes tokenizer training script |
| recipes/KsponSpeech/Tokenizer/ksponspeech_prepare.py | Removes symlink to parent preparation script |
| recipes/KsponSpeech/Tokenizer/hparams/5K_unigram_subword_bpe.yaml | Removes tokenizer hyperparameter configuration |
| recipes/KsponSpeech/Tokenizer/README.md | Removes tokenizer documentation |
| recipes/KsponSpeech/README.md | Removes main KsponSpeech recipe documentation |
| recipes/KsponSpeech/LM/train.py | Removes language model training script |
| recipes/KsponSpeech/LM/ksponspeech_prepare.py | Removes symlink to parent preparation script |
| recipes/KsponSpeech/LM/hparams/transformer.yaml | Removes LM hyperparameter configuration |
| recipes/KsponSpeech/LM/README.md | Removes LM documentation |
| recipes/KsponSpeech/ASR/transformer/train.py | Removes ASR training script with Conformer/Transformer implementation |
| recipes/KsponSpeech/ASR/transformer/ksponspeech_prepare.py | Removes symlink to parent preparation script |
| recipes/KsponSpeech/ASR/transformer/hparams/conformer_medium.yaml | Removes ASR hyperparameter configuration |
| recipes/KsponSpeech/ASR/transformer/README.md | Removes ASR documentation |
| README.md | Removes KsponSpeech from the list of supported Speech Recognition datasets |
| PERFORMANCE.md | Removes KsponSpeech ASR performance metrics section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We've had many issues regarding ksponspeech. Furthermore, the dataset is not accessible for non-korean citizens making it almost impossible to maintain actively. Given the discussion (#2748 (comment)), I propose to remove the recipe as well as the HF models. Once merged, I will close the related 4 ongoing issues.
Before submitting
PR review
Reviewer checklist