Make run_on_main and main_process_only return the result to all proce…#2943
Merged
pplantinga merged 1 commit intospeechbrain:developfrom Jul 9, 2025
Merged
Make run_on_main and main_process_only return the result to all proce…#2943pplantinga merged 1 commit intospeechbrain:developfrom
pplantinga merged 1 commit intospeechbrain:developfrom
Conversation
pplantinga
approved these changes
Jul 9, 2025
Collaborator
pplantinga
left a comment
There was a problem hiding this comment.
LGTM - returning the result from these functions is a natural extension, just one we haven't needed until now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes
run_on_mainandmain_process_onlyto allow the function that is run on one process to return a value.This value is returned on all processes. There is a new test to check this.
I am using this behaviour in internal code. (To be honest, initially I assumed this behaviour would be already there.)
In theory, this is a breaking change. But I believe that in the current codebase,
run_on_mainandmain_process_onlyare only used on functions that returnNone. This would be a breaking change where both these conditions are met:None;Nonebeing returned instead of whatever the function returns.It seems unlikely that both of these are true in any current code.
Before submitting
PR review
Reviewer checklist