Change location from which to import tqdm#2921
Merged
pplantinga merged 1 commit intospeechbrain:developfrom May 19, 2025
Merged
Change location from which to import tqdm#2921pplantinga merged 1 commit intospeechbrain:developfrom
pplantinga merged 1 commit intospeechbrain:developfrom
Conversation
pplantinga
approved these changes
May 19, 2025
Collaborator
pplantinga
left a comment
There was a problem hiding this comment.
I'm really not sure why you would import tqdm from tqdm.contrib as that submodule is for emulating builtins, e.g. tzip and tmap
Anyway, LGTM
pplantinga
pushed a commit
to pplantinga/speechbrain
that referenced
this pull request
Jun 2, 2025
Co-authored-by: Rogier van Dalen <r.vandalen@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This replaces
from tqdm.contrib import tqdmbyfrom tqdm import tqdm, i.e. removing.contrib.I believe this is (nowadays?) the standard way of importing this. Pyright stumbles over the current import (see #2901), but I haven't got a huge degree of insight into why.
Before submitting
PR review
Reviewer checklist