Skip to content

Streaming recipe for BestRQ#2790

Merged
TParcollet merged 8 commits intospeechbrain:developfrom
Chaanks:bestrq-streaming
May 28, 2025
Merged

Streaming recipe for BestRQ#2790
TParcollet merged 8 commits intospeechbrain:developfrom
Chaanks:bestrq-streaming

Conversation

@Chaanks
Copy link
Copy Markdown
Collaborator

@Chaanks Chaanks commented Dec 21, 2024

What does this PR do?

Add streaming recipe for BestRQ on LibriSpeech

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@Chaanks
Copy link
Copy Markdown
Collaborator Author

Chaanks commented Dec 21, 2024

@Adel-Moumen


sb.utils.distributed.ddp_init_group(run_opts)

with open(hparams_file, encoding="utf-8") as fin:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Copy Markdown
Collaborator

@TParcollet TParcollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chaanks, the requested changes are very minimal. Once done, we can merge it.

Comment thread recipes/LibriSpeech/self-supervised-learning/BEST-RQ/train.py Outdated
@pplantinga pplantinga added the recipes Changes to recipes only (add/edit) label Jan 16, 2025
@Adel-Moumen
Copy link
Copy Markdown
Collaborator

Thanks @Chaanks, the requested changes are very minimal. Once done, we can merge it.

Should we move forward on our side? I don't think this PR needs much efforts to get into SpeechBrain codebase.

Copy link
Copy Markdown
Collaborator

@TParcollet TParcollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TParcollet TParcollet merged commit 20ee80a into speechbrain:develop May 28, 2025
5 checks passed
pplantinga pushed a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
Co-authored-by: Adel Moumen <adelmoumen.pro@gmail.com>
Co-authored-by: Titouan Parcollet <parcollet.titouan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipes Changes to recipes only (add/edit)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants