Repository navigation
multi-speaker tacotron2 enhancements - #2261
Merged
Merged
Conversation
…ngth to 10 seconds
Collaborator
Author
|
Hi @mravanelli @pradnya-git-dev , for now I'm still trying to make the alignments work with more speakers by adding |
mravanelli
marked this pull request as ready for review
December 13, 2023 18:02
Collaborator
|
Thank you @BenoitWang for the improvements. I tested and everything runs. As mentioned, we can merge this PR and follow up in the future with another one for further changes. |
mravanelli
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi @mravanelli @pradnya-git-dev, as discussed, this PR contains some enhancements of the multi-speaker tacotron2 (#2120) based on my experiments.
The modifications are: