Skip to content

Fix for #1886#1890

Merged
Adel-Moumen merged 4 commits intospeechbrain:developfrom
anautsch:develop
Mar 21, 2023
Merged

Fix for #1886#1890
Adel-Moumen merged 4 commits intospeechbrain:developfrom
anautsch:develop

Conversation

@anautsch
Copy link
Copy Markdown
Collaborator

@anautsch anautsch commented Mar 20, 2023 •
edited
Loading

As pointed out in #1886 it's an out-dated check.

speechbrain/speechbrain/processing/features.py

Lines 148 to 173 in beec862

if version.parse(torch.__version__) <= version.parse("1.6.0"):
stft = torch.stft(
x,
self.n_fft,
self.hop_length,
self.win_length,
self.window.to(x.device),
self.center,
self.pad_mode,
self.normalized_stft,
self.onesided,
)
else:
stft = torch.stft(
x,
self.n_fft,
self.hop_length,
self.win_length,
self.window.to(x.device),
self.center,
self.pad_mode,
self.normalized_stft,
self.onesided,
return_complex=False,
)

I dropped the if branch of the statement.

Note: the then branch adds return_complex=False, to the parameters.

@Adel-Moumen Adel-Moumen self-assigned this Mar 21, 2023
Adel-Moumen
Adel-Moumen approved these changes Mar 21, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Adel-Moumen Adel-Moumen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adel-Moumen Adel-Moumen merged commit c18f620 into speechbrain:develop Mar 21, 2023
@Adel-Moumen Adel-Moumen mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Adel-Moumen Adel-Moumen Adel-Moumen approved these changes

Assignees

@Adel-Moumen Adel-Moumen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anautsch @Adel-Moumen