minor fixes for recipe testing#1872
Merged
Adel-Moumen merged 3 commits intospeechbrain:developfrom Mar 9, 2023
Merged
Conversation
Adel-Moumen
reviewed
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @Adel-Moumen pointed out in the 751 PR, there are some open tasks with the recipe testing. Here are some fixes. Added a missing extra requirements also.
The REAL-M recipe fix touches on its inner logic. Two nested flags are used to create a specfic field, if both are true - in this testing example, however, only one of them is and so, the recipe test fails for a later component expecting that specific field which never would be created, since one of the flags is False. That's addressed now with adding the least changes to the recipe.
Please merge first to develop & then fetch/merge the develop into pending PRs (+unstable branch).
cc @TParcollet