Merged
Conversation
pplantinga
approved these changes
Jan 16, 2023
Collaborator
pplantinga
left a comment
There was a problem hiding this comment.
Nice fix! LGTM
Its curious that these are the only two instances of this kind of code. Makes me wonder if its necessary at all or if there's another way it could be done. E.g. the input is always floating point so .to(input.device) is all that is needed.
|
When this will be released? Otherwise im gonna just change my local code 🤔 |
Collaborator
Author
|
@mattiasu96 please do :
It will download and install the new SpeechBrain version with the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for the mac MPS error #1794
It works perfectly as expected on my mac m1 with this fix.
Please note that MPS is not yet supported for all operations, and in #1794 it will be necessary to run the script with PYTORCH_ENABLE_MPS_FALLBACK=1