Added workaround for CyclicLR saving#1683
Merged
anautsch merged 1 commit intospeechbrain:developfrom Nov 3, 2022
Merged
Conversation
anautsch
approved these changes
Nov 3, 2022
Collaborator
anautsch
left a comment
There was a problem hiding this comment.
lgtm - thank you for the adhoc fix !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds special saver/loader for CyclicLR since they have weakref.WeakMethods, which cannnot be pickled. Fortunately, those are not really state that gets updated during training, but rather they are reconstructed if the new instance is created with the same arguments (i.e. no custom scale function suddenly). Trying to detect this anyway, but only raise a warning - maybe users know what they are doing.