In filter_ctc_output(), remove redundant filtering#1584
Merged
anautsch merged 1 commit intospeechbrain:developfrom Sep 26, 2022
olvb:faster-ctc-filtering
Merged
In filter_ctc_output(), remove redundant filtering#1584anautsch merged 1 commit intospeechbrain:developfrom olvb:faster-ctc-filtering
anautsch merged 1 commit intospeechbrain:developfrom
olvb:faster-ctc-filtering
Conversation
Before this commit we were filtering out twice the repeated tokens: once with the list comprehension and once with groupby.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that in
filter_ctc_output()we had 2 blocks of code performing the same task: merging repeated tokens.I kept the
groupby()rather than the list comprehension as it appears to be faster.