Repository navigation
mig: drop sso_connection_id column from organization_metadata - #2247
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6003dcd to
c08599c
Compare
c407c50 to
bc44797
Compare
e7aac86 to
bc914ea
Compare
bc44797 to
0555bc0
Compare
bc914ea to
aee305f
Compare
0555bc0 to
fc77c11
Compare
aee305f to
54ccee2
Compare
729cb08 to
0617c5f
Compare
fc77c11 to
1e626bd
Compare
0617c5f to
c89c02a
Compare
1e626bd to
446273a
Compare
c89c02a to
a8f75b1
Compare
446273a to
715af1b
Compare
715af1b to
2097ca5
Compare
63acce0 to
2c5516b
Compare
2097ca5 to
eeb9bab
Compare
…de (#2246) Remove all dependencies on `sso_connection_id`, there are no more dependencies on it and it seems to confuse humans and Claude alike. This PR changes behavior to target `workos_id` as a column instead of `sso_connection_id`. After we merge it, we should run the following data migration: ```sql UPDATE organization_metadata SET workos_id = sso_connection_id, updated_at = clock_timestamp() WHERE sso_connection_id IS NOT NULL AND workos_id IS NULL; ``` There is [a follow-up PR](#2247) to drop the column. We first merge the behavior change and let it run for a couple days to avoid risks of data loss. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bflad
left a comment
There was a problem hiding this comment.
This PR adds or modifies server/gen/http/openapi3.json, which was intentionally untracked on main in #3935. That file is a generated, single-line duplicate of openapi3.yaml that nothing consumes (the server embeds the yaml and Speakeasy reads the yaml), and it is ignored via .gitignore (line 36). Because it was tracked and ignored at the same time, it kept churning and producing rebase conflicts.
Merging this PR as-is would re-introduce the tracked file and revive that recurring conflict. Please drop it from this PR:
git rm --cached server/gen/http/openapi3.json
git commit -m "chore: stop tracking generated openapi3.json"
Rebasing on the latest main also resolves it. The file stays on disk and gitignored; openapi3.yaml remains the tracked, consumed artifact. Thanks!
7a6d04a to
e444fc2
Compare
|
|
||||||||||||||||
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
1b2bd02 to
af1b2cc
Compare
|
|
||||||||||||||||
Remove the column from the schema and add the corresponding migration. The behavior change moving reads and writes onto workos_id shipped in #2246 and has been running in production since April. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
af1b2cc to
8ae8565
Compare
Follow-up to #2246. Drops the
sso_connection_idcolumn fromorganization_metadataafter the behavior change has been running in production and the data migration has been executed.