Avoid using deprecated Buffer constructor#53
Closed
ChALkeR wants to merge 1 commit intospdy-http2:masterfrom
Closed
Avoid using deprecated Buffer constructor#53ChALkeR wants to merge 1 commit intospdy-http2:masterfrom
ChALkeR wants to merge 1 commit intospdy-http2:masterfrom
Conversation
safe-buffer is already used and provides Buffer.alloc polyfill, so just use Buffer.alloc directly to avoid hitting deprecated API. Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Contributor
|
I added this into the latest fixes for node LTS support #61 and it is available in spdy-transport@3.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safe-bufferis already used and providesBuffer.allocpolyfill, so just useBuffer.allocdirectly to avoid hitting deprecated API.Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Tracking: nodejs/node#19079