Skip to content

Exclude repos by glob - #70

Merged
brendan-kellam merged 5 commits into
sourcebot-dev:mainfrom
Steven-Nagie:exclude-repos-by-glob
Nov 14, 2024
Merged

brendan-kellam merged 5 commits into
sourcebot-dev:mainfrom
Steven-Nagie:exclude-repos-by-glob

Conversation

@Steven-Nagie

Copy link
Copy Markdown
Contributor

References #69

@brendan-kellam brendan-kellam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!! Left a couple of nit comments. Could you also add a example of glob patterns being used to configs/filter.json.

Comment thread packages/backend/src/utils.test.ts
Comment thread schemas/v2/index.json Outdated
Comment thread schemas/v2/index.json Outdated
Comment thread schemas/v2/index.json Outdated
Comment thread schemas/v2/index.json Outdated
Comment thread schemas/v2/index.json
Comment thread schemas/v2/index.json Outdated
…nt and updated description for exclude repos/projects in schema json, improved existing micromatch test and added test for name exact match
@Steven-Nagie

Copy link
Copy Markdown
Contributor Author

All good calls, addressed everything.

@brendan-kellam
brendan-kellam merged commit a407792 into sourcebot-dev:main Nov 14, 2024
@brendan-kellam

Copy link
Copy Markdown
Contributor

Merged. Thanks for the contribution @Steven-Nagie!

@Steven-Nagie

Copy link
Copy Markdown
Contributor Author

Merged. Thanks for the contribution @Steven-Nagie!

Thank you! Sourcebot has been a big help, happy to contribute in my small way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants