Repository navigation
fix: fix javascript btoa function can not handle Unicode strings issue - #38
Merged
Merged
Conversation
ttys3
force-pushed
the
fix-atob-utf-8-bug
branch
2 times, most recently
from
October 15, 2024 11:49
ba74de5 to
2df7ede
Compare
ttys3
marked this pull request as draft
October 15, 2024 12:42
ttys3
force-pushed
the
fix-atob-utf-8-bug
branch
from
October 15, 2024 13:11
2df7ede to
87dffb4
Compare
ttys3
marked this pull request as ready for review
October 15, 2024 14:00
brendan-kellam
approved these changes
Oct 16, 2024
Contributor
|
Thanks for the fix!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://web.dev/articles/base64-encoding#strings_in_unicode_and_javascript
https://stackoverflow.com/questions/30106476/using-javascripts-atob-to-decode-base64-doesnt-properly-decode-utf-8-strings
https://stackoverflow.com/questions/8936984/uint8array-to-string-in-javascript