Skip to content

Graceful error handling when calling code host apis - #142

Merged
brendan-kellam merged 6 commits into
mainfrom
bkellam/error_handling
Dec 19, 2024
Merged

brendan-kellam merged 6 commits into
mainfrom
bkellam/error_handling

Conversation

@brendan-kellam

@brendan-kellam brendan-kellam commented Dec 19, 2024 •

Copy link
Copy Markdown
Contributor

The following adds graceful error handling for code host api calls. When a api call fails, an error message is raised and the config synchronization continues. Fixes #140

The side-effect of this is that if an api experiences some transient error (e.g., network issue, rate limits, etc.), then repositories will be marked stale when they actually are not. If autoDeleteStaleRepos is enabled, then the repo & it's index will be deleted.

Two things we can do come to mind:

  1. We add a delay between when a repo is marked stale and when it is deleted. This way, it gives the config a change to be re-synced again (and the transient issues gone).
  2. We add retry mechanisms to api calls s.t., we retry on known failures.

@brendan-kellam
brendan-kellam merged commit 03aa608 into main Dec 19, 2024
@brendan-kellam
brendan-kellam deleted the bkellam/error_handling branch December 19, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hangs at first error (GitLab group innaccessible)

1 participant