feat(web): add repo browsing without requiring a search first#1100
feat(web): add repo browsing without requiring a search first#1100h30s wants to merge 2 commits intosourcebot-dev:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughAdds explicit entry points for repository browsing: a TopBar action button, updated navigation active-state logic for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/web/src/app/`(app)/components/navigationMenu/navigationItems.tsx:
- Around line 29-31: The active-state check using startsWith in the block that
handles href === '/repos' is too permissive; change the logic that currently
returns pathname.startsWith('/repos') || pathname.startsWith('/browse') to
perform exact-or-subpath matching (e.g., pathname === '/repos' ||
pathname.startsWith('/repos/') and similarly for '/browse') so unrelated
prefixes like '/browseXYZ' don't match; update the condition in the function
handling href === '/repos' (reference: href and pathname checks in
navigationItems.tsx) to use these exact-or-subpath checks or a small helper like
isExactOrSubpath(prefix, pathname).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c14fcc13-2c73-4ab1-bd36-6c76ef6f1bbb
📒 Files selected for processing (4)
packages/web/src/app/(app)/browse/layoutClient.tsxpackages/web/src/app/(app)/components/navigationMenu/navigationItems.tsxpackages/web/src/app/(app)/repos/page.tsxpackages/web/src/app/(app)/search/components/searchLandingPage.tsx
packages/web/src/app/(app)/components/navigationMenu/navigationItems.tsx
Show resolved
Hide resolved
|
@msukkari PTAL |
|
@h30s I'm going to close this PR as we are currently re-working the UI to fulfill this requirement. For future reference, please discuss with us prior to opening a PR that makes changes to the UI or core product, as outlined in the CONTRIBUTING.md |
ah got it 👍will discuss first next time before pushing UI changes |
Summary
Fixes #472
Summary by CodeRabbit