Skip to content

fix: hmr support for hoisted functions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryansolid merged 2 commits into from
Mar 4, 2026
Merged

fix: hmr support for hoisted functions #84

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7ee0f
Update index.ts
lxsmnsyc Mar 4, 2026
ab3cb80
fix snapshots
lxsmnsyc Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update index.ts
  • Loading branch information
@lxsmnsyc
lxsmnsyc committed Mar 4, 2026
commit 2c7ee0f5c8933d450418ea23057f4e7468e956c3
9 changes: 5 additions & 4 deletions src/babel/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,6 @@ function bubbleFunctionDeclaration(
// have zero or one parameter
decl.params.length < 2
) {
const first = program.get('body')[0];
const [tmp] = first.insertBefore(decl);
program.scope.registerDeclaration(tmp);
tmp.skip();
if (path.parentPath.isExportNamedDeclaration()) {
path.parentPath.replaceWith(
t.exportNamedDeclaration(undefined, [
Expand All @@ -324,6 +320,9 @@ function bubbleFunctionDeclaration(
} else {
path.remove();
}
const [tmp] = program.unshiftContainer('body', [decl]);
program.scope.registerDeclaration(tmp);
tmp.skip();
}
}
}
Expand Down Expand Up @@ -361,6 +360,7 @@ export default function solidRefreshPlugin(): babel.PluginObj<State> {
bubbleFunctionDeclaration(programPath, path);
},
});
programPath.scope.crawl();
if (state.jsx) {
programPath.traverse({
JSXElement(path) {
Expand All @@ -370,6 +370,7 @@ export default function solidRefreshPlugin(): babel.PluginObj<State> {
transformJSX(path);
},
});
programPath.scope.crawl();
}
programPath.traverse({
VariableDeclarator(path) {
Expand Down