-
Notifications
You must be signed in to change notification settings - Fork 356
SolidStart: expand docs on rendering modes #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atilafassina
wants to merge
124
commits into
main
Choose a base branch
from
docs/rendering-modes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
124 commits
Select commit
Hold shift + click to select a range
c83f957
expand docs on rendering modes
atilafassina 28afce1
typo-1
atilafassina 2e8d401
typo-2
atilafassina 7a73d35
typo-3
atilafassina 926ff16
typo-4
atilafassina 08b8670
typooo
atilafassina 41d8ff0
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3207564
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 4bdba75
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] a02ed4c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 4d313c3
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] b7fb815
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 717bca0
big rewording
atilafassina c56434a
Update src/routes/solid-start/building-your-application/rendering-mod…
atilafassina ea97511
Update src/routes/solid-start/building-your-application/rendering-mod…
atilafassina 142c87f
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] e09cc3c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] bd9cbed
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d3a447d
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 2b21ae7
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3449f45
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 5c40d3d
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] c3cb991
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 0a7f7ec
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 889b9d7
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] eb2cd49
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 75c77b2
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 6738c75
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] ff476f4
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 33cfb0a
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 73f9a73
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 0caf6a8
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] fe7ec3b
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 6488ad2
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] c0dc8a1
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 4cee9c7
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] b3e80f0
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 1ca1016
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 7aa30aa
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 979c797
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] cdc39f1
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 67296bb
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 197fb7c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3ad0b03
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 9c71b99
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 10eafa5
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 70ad680
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 429cc3c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 0dec3e3
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 4d0a92d
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3afd28e
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d899217
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] edd2612
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 105b1bb
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] e957f66
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] e704cbf
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 439762a
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] ba6ad25
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] c9ef58a
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] b9b69c3
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 9e9ebc2
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 178b62a
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 6da40d8
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 557ba8f
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 23b4e51
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 03d7fab
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 052a62d
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d418b94
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 18b4dbd
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] ba521e3
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 22a89b5
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 982e47d
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 532474f
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 594993d
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] c90967b
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 69605a8
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 9257d55
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 9d6b0b3
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d16b1c6
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] f264a72
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] bc99819
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 6ab326a
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d751bd1
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] b7a59ea
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] efb8f2e
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] ca3b792
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d644381
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] e4275b7
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] ecc2cb0
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] ea3dd6e
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 6fd94c4
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 131f708
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3421b5c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3ef80b8
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 9c7bf29
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 006d17c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] e9e804b
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d6b5663
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 47792ff
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] a641d40
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 28a433e
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 2ab9272
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 161f9f0
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 9b9a723
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 570943f
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] f0fbd0a
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] c1ce624
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] f2d92b3
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 773cce8
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] aa0dde6
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 7d3fbdf
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3a30eee
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 1cc0fb9
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 904471b
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] c7dbf09
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 7c9cad7
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 2b76d35
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 4e98805
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] bbb09c0
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 8e3765c
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 5fc2337
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 3b2a2f2
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] 1865ded
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] d8f4a70
Merge branch 'main' into docs/rendering-modes
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
typooo
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Loading branch information
commit 08b8670cc84a73e1bf30b443ea7d7cb8aa2c77f6
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as Comment 3: The function should directly return the object
({ mode: isBot(event.request.userAgent) ? \"async\" : \"stream\" })without the explicit return statement and extra braces, to match the type signature.