fix: position calculation in createVirtual function with animations disabled#24
Open
luccalaz wants to merge 1 commit into
Open
fix: position calculation in createVirtual function with animations disabled#24luccalaz wants to merge 1 commit into
luccalaz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
wrapis enabled on aVirtualRow/VirtualColumnandConfig.animationsEnabledisfalse, navigating through the carousel causes the container to scroll more than expected on every keypress. The selected tile highlight moves correctly while the row visually overshoots.Root cause
The
onSelectedChangedhandler has two code paths — one animated, one not. The animation path correctly resets the container to an absolute position before applying the wrap shift:The non-animation path was missing this reset:
When wrap navigation occurs, virtual children are repositioned in the DOM, which changes
active[axis]— the focused child's local offset within the container. Without first normalisingthis.lng[axis]viaprevChildPos - active[axis], the shift is applied on top of an already-stale container position, causing a double-scroll.Fix