NH-91749: use the new extended span processor#267
Merged
Conversation
…an before it's ended. refactor the test because some stuff don't make sense anymore.
swi-jared
approved these changes
Sep 30, 2024
|
For posterity, should anyone be unaware of the context of these changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tl;dr: Set
sw.transactionwith new Span APIContext:
Leverage the new
ExtendedSpanProcessorto mutate span before it's ended. This API provides a cleaner way to setsw.transactionon OTel spans though it's still experimental. Refactored code to remove codes that are now redundant. Also made changes in the test because some stuff don't make sense anymore and added additional test to verify that the Lambda custom transaction name setting works with the new api.Test Plan:
Test services data 0, 1, 2 and 3