Improve rest support, add total items to list results#640
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
FYI, converting to a list is required for this code because it uses the result of a list API call in a subsequent API call. Unfortunately, the XMLRPC library uses the exact type instead of using instanceof so it will error now because it does not know about SoftLayerListResult. This could be considered a breaking change... However, this is the only instance that I've found in all of the manager code.
Member
|
LGTM, thanks for adding this. |
briancline
added a commit
that referenced
this pull request
Nov 20, 2015
Improve rest support, add total items to list results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
total_countattribute available which can tell you how many total items exist which satisfy your list query.