Skip to content

Resolves issue with slcli loadbal service-add #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudorandom merged 4 commits into from
Jun 15, 2015
Merged

Resolves issue with slcli loadbal service-add #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79e2c8d
correct arguement name
Neetuj May 14, 2015
97e0d92
change argument name
Neetuj May 14, 2015
bdff0e2
cleaning
Neetuj May 26, 2015
b4484ef
Fix small style issue
Jun 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions SoftLayer/CLI/loadbal/service_add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
@click.option('--healthcheck-type',
required=True,
help="The health check type")
@click.option('--ip-address', '--ip',
@click.option('--ip-address',
required=True,
help="The IP of the service")
help="The IP address of the service")
@environment.pass_env
def cli(env, identifier, enabled, port, weight, healthcheck_type, ip_address):
"""Adds a new load balancer service."""
Expand All @@ -40,7 +40,8 @@ def cli(env, identifier, enabled, port, weight, healthcheck_type, ip_address):
if ip_address:
ip_service = env.client['Network_Subnet_IpAddress']
ip_record = ip_service.getByIpAddress(ip_address)
ip_address_id = ip_record['id']
if len(ip_record) > 0:
ip_address_id = ip_record['id']

mgr.add_service(loadbal_id,
group_id,
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/testing/xmlrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ def create_test_server(transport, host='localhost', port=0):
"""Create a test XML-RPC server in a new thread."""
server = TestServer(transport, (host, port), TestHandler)
thread = threading.Thread(target=server.serve_forever,
kwargs={'poll_interval': 0.05})
kwargs={'poll_interval': 0.01})
thread.start()
return server