Issue550#551
Closed
Neetuj wants to merge 3 commits into
Closed
Conversation
Contributor
|
@Neetuj yeah, it is weird that an ip address is required but it looks like it tries to go on without finding a ip record anyway. |
Contributor
There was a problem hiding this comment.
There should be a space before and after the > sign.
Member
Author
There was a problem hiding this comment.
Ahh ... Thnx
Sent from my iPhone
On May 14, 2015, at 5:30 PM, sudorandom notifications@github.com wrote:
In SoftLayer/CLI/loadbal/service_add.py:
ip_service = env.client['Network_Subnet_IpAddress']
ip_record = ip_service.getByIpAddress(ip_address)ip_address_id = ip_record['id']ip_record = ip_service.getByIpAddress(ip)if len(ip_record)>0:—
Reply to this email directly or view it on GitHub.
Contributor
|
The tests have been fixed in master. Please rebase in order to get the changes: |
Contributor
|
Closed in favor of #562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will correct the argument issue( which is causing the name confusion)
From UI perspective I think it should be ip rather than ip_address ( too long for an argument name to type)
I also catch the case when ip_record is null before referencing it. Should i throw an error if its not found ?