Skip to content

Hardware cancel consolidation#524

Merged
underscorephil merged 2 commits into
softlayer:masterfrom
sudorandom:hardware-cancel
Apr 20, 2015
Merged

Hardware cancel consolidation#524
underscorephil merged 2 commits into
softlayer:masterfrom
sudorandom:hardware-cancel

Conversation

@sudorandom
Copy link
Copy Markdown
Contributor

@sudorandom sudorandom commented Apr 14, 2015

This should resolve #522.

  • HardwareManager.cancel_metal() is removed in favor of HardwareManager.cancel_hardware()
  • HardwareManager.cancel_hardware() now uses SoftLayer_Billing_Item::cancelItem() which (I think) works on most cancelable items.

@landscape-bot
Copy link
Copy Markdown

landscape-bot commented Apr 14, 2015

Code Health
Code quality remained the same when pulling 769d900 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 14, 2015

Coverage Status

Coverage decreased (-0.02%) to 85.61% when pulling 769d900 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@landscape-bot
Copy link
Copy Markdown

landscape-bot commented Apr 14, 2015

Code Health
Code quality remained the same when pulling ab50844 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 14, 2015

Coverage Status

Coverage decreased (-0.02%) to 85.61% when pulling ab50844 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@sudorandom sudorandom mentioned this pull request Apr 15, 2015
Merged
@sudorandom
Copy link
Copy Markdown
Contributor Author

sudorandom commented Apr 15, 2015

@underscorephil Do you know if SoftLayer_Billing_Item::cancelItem() is the method to use that can cancel most things? I know they did a lot of work to consolidate cancellation but it's not obvious in the documentation which one should be used.

@underscorephil
Copy link
Copy Markdown
Contributor

underscorephil commented Apr 17, 2015

@sudorandom doing some research to make sure my info is up to date. Will keep you in the loop

@sudorandom
Copy link
Copy Markdown
Contributor Author

sudorandom commented Apr 17, 2015

@underscorephil so it looks like SoftLayer_Billing_Item::cancelItem is the universal cancel method. That will likely simplify a lot. I think this change is ready.

@underscorephil
Copy link
Copy Markdown
Contributor

underscorephil commented Apr 20, 2015

LGTM

underscorephil added a commit that referenced this pull request Apr 20, 2015
@underscorephil
Merge pull request #524 from sudorandom/hardware-cancel
7fa51cf 
Hardware cancel consolidation
@underscorephil underscorephil merged commit 7fa51cf into softlayer:master Apr 20, 2015
@sudorandom sudorandom deleted the hardware-cancel branch December 4, 2015 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

problem with hourly bare metal servers immediate cancelation in CLI and manager

4 participants

@sudorandom @landscape-bot @coveralls @underscorephil