Skip to content

adding import image#447

Merged
sudorandom merged 6 commits into
softlayer:masterfrom
Neetuj:issue420
Dec 9, 2014
Merged

adding import image#447
sudorandom merged 6 commits into
softlayer:masterfrom
Neetuj:issue420

Conversation

@Neetuj
Copy link
Copy Markdown
Member

@Neetuj Neetuj commented Nov 11, 2014

have not yet tested it with valid URIs ..need to still add valid uri testcases and find out if i need to vlaidate osrefcode in cli or let it fail. putting it out for initial review.
Also should we display anything after the call finishes ? I return currenlty id, name .. should it be used to display "assurance message: that "name was imported" ?

@sudorandom
Copy link
Copy Markdown
Contributor

@Neetuj The UUID (and/or ID) is likely the most important part to output (and return from the manager). This gives the ability to check on the status of the import and actually use once the import is done. Take a look at the output when creating a virtual server for comparison. Without an ID, the only way to look it up is by the name which isn't guaranteed to unique or simple to input into a CLI (since spaces in the name will require wrapping the name in quotes).

@Neetuj
Copy link
Copy Markdown
Member Author

Neetuj commented Nov 11, 2014

ok

On Tue, Nov 11, 2014 at 3:10 PM, Kevin McDonald notifications@github.com
wrote:

@Neetuj https://github.com/Neetuj The UUID (and/or ID) is likely the
most important part to output (and return from the manager). This gives the
ability to check on the status of the import and actually use once the
import is done. Take a look at the output when creating a virtual server
for comparison. Without an ID, the only way to look it up is by the name
which isn't guaranteed to unique or simple to input into a CLI (since
spaces in the name will require wrapping the name in quotes).


Reply to this email directly or view it on GitHub
#447 (comment)
.

@sudorandom
Copy link
Copy Markdown
Contributor

Just to make sure you're aware, it's possible to run all the tests using the tox command (pip install tox) locally. It will fail for python versions that you don't have, but it should give you good feedback without having to commit, push and wait for travis-ci.

Comment thread SoftLayer/tests/managers/image_tests.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inappropriate comment

@Neetuj
Copy link
Copy Markdown
Member Author

Neetuj commented Nov 14, 2014

This works i was finally able to test it.

(slenv)~/office/softlayer-python (issue420) > sl image import test swift://SLOS13193-**@sjc01/newtest1/marquee--0.vhd  --osrefcode CENTOS_6_32{'operatingSystemReferenceCode': u'CENTOS_6_32', 'name': u'test', 'uri': u'swift://SLOS13193-1@sjc01/newtest1/marquee--0.vhd'}
:.........:......................................:
:    name : value                                :
:.........:......................................:
:    name : test                                 :
:      id : 315544                               :
: created : 2014-11-14T13:33:38-06:00            :
:    guid : d167ef9b-c7fc-4b39-a72b-80242bbfcac7 :

sudorandom added a commit that referenced this pull request Dec 9, 2014
@sudorandom sudorandom merged commit e68b5b8 into softlayer:master Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants