Skip to content

Add prices to vs create-options.#1351

Merged
allmightyspiff merged 3 commits into
softlayer:masterfrom
FernandoOjeda:ft_vs_create_options_prices
Oct 5, 2020
Merged

Add prices to vs create-options.#1351
allmightyspiff merged 3 commits into
softlayer:masterfrom
FernandoOjeda:ft_vs_create_options_prices

Conversation

@FernandoOjeda

Copy link
Copy Markdown
Contributor

Add prices to vs create-options #1325.

@FernandoOjeda FernandoOjeda self-assigned this Sep 22, 2020
@allmightyspiff allmightyspiff added the Ordering Anything related to ordering label Sep 28, 2020
@allmightyspiff

allmightyspiff commented Sep 28, 2020

Copy link
Copy Markdown
Member

testing

✔️ slcli -v --format=table vs create-options --prices tok02
✔️ slcli -v --format=table vs create-options --prices
✔️ slcli -v --format=table vs create-options
✔️ slcli -v --format=table vs create-options --prices --vsi-type PUBLIC_CLOUD_SERVER

@allmightyspiff allmightyspiff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works great, but needs a few changes to the CLI code to make it read a bit easier.

Also, I don't think the RAM/CORE/Network/Extra categories have capacity restrictions, so we can just remove those from those tables.

Comment thread SoftLayer/CLI/virt/create_options.py Outdated
Comment thread SoftLayer/CLI/virt/create_options.py Outdated
Comment thread SoftLayer/CLI/virt/create_options.py Outdated
Comment thread SoftLayer/CLI/virt/create_options.py Outdated
Comment thread SoftLayer/CLI/virt/create_options.py Outdated
@allmightyspiff allmightyspiff merged commit 76a7fbf into softlayer:master Oct 5, 2020
@allmightyspiff allmightyspiff linked an issue Nov 17, 2020 that may be closed by this pull request
@allmightyspiff allmightyspiff mentioned this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ordering Anything related to ordering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor slcli vs create-options

2 participants