Skip to content

Cherry pick bug fix from 3.x#274

Merged
straybirdzls merged 3 commits intosofastack:2.5.xfrom
QilongZhang:cherry-pick-bug-fix
Nov 16, 2018
Merged

Cherry pick bug fix from 3.x#274
straybirdzls merged 3 commits intosofastack:2.5.xfrom
QilongZhang:cherry-pick-bug-fix

Conversation

@QilongZhang
Copy link
Copy Markdown
Contributor

@QilongZhang QilongZhang commented Nov 16, 2018

No description provided.

@QilongZhang QilongZhang added the bug Something isn't working label Nov 16, 2018
@QilongZhang QilongZhang added this to the 2.5.2 milestone Nov 16, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 16, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 605

  • 54 of 58 (93.1%) changed or added relevant lines in 3 files are covered.
  • 52 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.5%) to 72.018%
Changes Missing Coverage Covered Lines Changed/Added Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/initializer/SofaRuntimeSpringContextInitializer.java 0 1 0.0%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/listener/SofaBootstrapRunListener.java 51 54 94.44%
Files with Coverage Reduction New Missed Lines %
isle-sofa-boot-starter/src/main/java/com/alipay/sofa/isle/spring/listener/SofaModuleContextRefreshedListener.java 1 72.41%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/initializer/SofaRuntimeSpringContextInitializer.java 1 0.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/integration/activator/SofaRuntimeActivator.java 1 0.0%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/endpoint/SofaBootVersionEndpoint.java 1 85.42%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/callback/CloseApplicationContextCallBack.java 1 75.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/ServiceFactoryBean.java 2 66.67%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/health/MultiApplicationHealthIndicator.java 2 56.25%
test-sofa-boot-starter/src/main/java/com/alipay/sofa/test/runner/SofaJUnit4Runner.java 3 56.67%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java 3 0.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/service/helper/ReferenceRegisterHelper.java 3 72.73%
Totals Coverage Status
Change from base Build 604: 0.5%
Covered Lines: 1642
Relevant Lines: 2280
💛 - Coveralls

@straybirdzls straybirdzls merged commit 0e3d94b into sofastack:2.5.x Nov 16, 2018
@QilongZhang QilongZhang deleted the cherry-pick-bug-fix branch December 26, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@straybirdzls straybirdzls straybirdzls approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

2.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongZhang @coveralls @straybirdzls