Removed control tower code for the start page (microsoft#13195)

David Kutugata · web-flow · commit b0cf27d98273 · 2020-07-29T17:04:17.000-07:00
diff --git a/news/3 Code Health/12919.md b/news/3 Code Health/12919.md
@@ -0,0 +1 @@
+Removed control tower code for the start page.
diff --git a/src/client/common/experiments/groups.ts b/src/client/common/experiments/groups.ts
@@ -80,11 +80,6 @@ export enum NotebookEditorSupport {
     nativeNotebookExperiment = 'NativeNotebook - experiment'
 }
 
-// Experiment to turn on the start page
-export enum EnableStartPage {
-    experiment = 'EnableStartPage'
-}
-
 // Experiment to remove the Kernel/Server Tooblar in the Interactive Window when running a local Jupyter Server.
 // It doesn't make sense to have it there, the user can already change the kernel
 // by changing the python interpreter on the status bar.
diff --git a/src/client/common/startPage/startPage.ts b/src/client/common/startPage/startPage.ts
@@ -19,9 +19,8 @@ import {
     IWebPanelProvider,
     IWorkspaceService
 } from '../application/types';
-import { EnableStartPage } from '../experiments/groups';
 import { IFileSystem } from '../platform/types';
-import { IConfigurationService, IExperimentService, IExtensionContext, Resource } from '../types';
+import { IConfigurationService, IExtensionContext, Resource } from '../types';
 import * as localize from '../utils/localize';
 import { StopWatch } from '../utils/stopWatch';
 import { StartPageMessageListener } from './startPageMessageListener';
@@ -51,8 +50,7 @@ export class StartPage extends WebViewHost<IStartPageMapping> implements IStartP
         @inject(IDocumentManager) private readonly documentManager: IDocumentManager,
         @inject(IApplicationShell) private appShell: IApplicationShell,
         @inject(IExtensionContext) private readonly context: IExtensionContext,
-        @inject(IApplicationEnvironment) private appEnvironment: IApplicationEnvironment,
-        @inject(IExperimentService) private readonly expService: IExperimentService
+        @inject(IApplicationEnvironment) private appEnvironment: IApplicationEnvironment
     ) {
         super(
             configuration,
@@ -244,10 +242,9 @@ export class StartPage extends WebViewHost<IStartPageMapping> implements IStartP
     }
 
     private async activateBackground(): Promise<void> {
-        const enabled = await this.expService.inExperiment(EnableStartPage.experiment);
         const settings = this.configuration.getSettings();
 
-        if (enabled && settings.showStartPage && this.appEnvironment.extensionChannel === 'stable') {
+        if (settings.showStartPage && this.appEnvironment.extensionChannel === 'stable') {
             // extesionVersionChanged() reads CHANGELOG.md
             // So we use separate if's to try and avoid reading a file every time
             const firstTimeOrUpdate = await this.extensionVersionChanged();
diff --git a/src/test/startPage/startPage.unit.test.ts b/src/test/startPage/startPage.unit.test.ts
@@ -16,7 +16,7 @@ import {
 import { IFileSystem } from '../../client/common/platform/types';
 import { StartPage } from '../../client/common/startPage/startPage';
 import { IStartPage } from '../../client/common/startPage/types';
-import { IConfigurationService, IExperimentService, IExtensionContext } from '../../client/common/types';
+import { IConfigurationService, IExtensionContext } from '../../client/common/types';
 import { ICodeCssGenerator, INotebookEditorProvider, IThemeFinder } from '../../client/datascience/types';
 import { MockPythonSettings } from '../datascience/mockPythonSettings';
 import { MockAutoSelectionService } from '../mocks/autoSelector';
@@ -36,7 +36,6 @@ suite('StartPage tests', () => {
     let context: typemoq.IMock<IExtensionContext>;
     let appEnvironment: typemoq.IMock<IApplicationEnvironment>;
     let memento: typemoq.IMock<Memento>;
-    let experiment: typemoq.IMock<IExperimentService>;
     const dummySettings = new MockPythonSettings(undefined, new MockAutoSelectionService());
 
     function setupVersions(savedVersion: string, actualVersion: string) {
@@ -71,7 +70,6 @@ suite('StartPage tests', () => {
         context = typemoq.Mock.ofType<IExtensionContext>();
         appEnvironment = typemoq.Mock.ofType<IApplicationEnvironment>();
         memento = typemoq.Mock.ofType<Memento>();
-        experiment = typemoq.Mock.ofType<IExperimentService>();
 
         configuration.setup((cs) => cs.getSettings(undefined)).returns(() => dummySettings);
 
@@ -87,8 +85,7 @@ suite('StartPage tests', () => {
             documentManager.object,
             appShell.object,
             context.object,
-            appEnvironment.object,
-            experiment.object
+            appEnvironment.object
         );
     });
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Removed control tower code for the start page.`