Skip to content

Removed control tower code for the start page#13195

Merged
DavidKutu merged 1 commit into
masterfrom
david/remvoveControlTower
Jul 30, 2020
Merged

Removed control tower code for the start page#13195
DavidKutu merged 1 commit into
masterfrom
david/remvoveControlTower

Conversation

@DavidKutu

Copy link
Copy Markdown

For #12919

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter

codecov-commenter commented Jul 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #13195 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13195      +/-   ##
==========================================
- Coverage   59.57%   59.54%   -0.03%     
==========================================
  Files         669      669              
  Lines       36788    36783       -5     
  Branches     5182     5181       -1     
==========================================
- Hits        21915    21902      -13     
- Misses      13778    13783       +5     
- Partials     1095     1098       +3     
Impacted Files Coverage Δ
src/client/common/experiments/groups.ts 100.00% <ø> (ø)
src/client/common/startPage/startPage.ts 31.21% <66.66%> (-0.67%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed52c5...74a90e9. Read the comment docs.

@DavidKutu DavidKutu merged commit b0cf27d into master Jul 30, 2020
@DavidKutu DavidKutu deleted the david/remvoveControlTower branch July 30, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants