Skip to content

Dockerize#1

Open
smadarasmi wants to merge 3 commits into
masterfrom
dockerize
Open

Dockerize#1
smadarasmi wants to merge 3 commits into
masterfrom
dockerize

Conversation

@smadarasmi
Copy link
Copy Markdown
Owner

No description provided.

Comment thread .gitignore
.vscode

# Mac OS
.DS_Store
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic I know, but add OS and personal choice tool-specific stuff like IDE cruft to your global gitignore, so you don't have to mess with it for every project: see git help gitignore, but TL;DR it's ~/.config/git/ignore

Comment thread charts/feast/values.yaml
type: "stdout"
warehouse:
type: "bigquery"
# options: '{"project": "gcp-project-id", "dataset": "feast"}'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to include changes to Helm config now, right?

Maybe this PR is just for sharing between us for the moment, that's fine. I don't know if the upstream project would want a docker-compose.yml contributed to the project or not since they'd probably encourage people to use Kubernetes + Helm locally instead, but if we do end up going with Feast then keeping it on our internal fork makes sense to me, for development convenience.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say keeping this, did you mean the docker-compose.yml file, or the change in values.yml file? I'm a little confused by the conclusion whether I should keep this or remove?
Or should I move this change to a different PR?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, by "keeping it" I did mean the Docker Compose file. I think that should be on the "Agoda master" branch that we presumably maintain going forward (though I agree with what you mentioned in chat, we should make it build from the Dockerfiles in the repo instead of referencing the gcr.io registry images—build: path/to/Dockerfile).

If we're not going to be using Kubernetes for the time being then I think we shouldn't merge any changes to the Helm configuration, it's just going to be potential conflict churn to work around when syncing up with upstream updates.

Comment thread docker-compose.yml
version: '3'
services:
core:
container_name: coreservice
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line, then update these below:

STORE_SERVING_OPTIONS: '{"host": "redis", "port": "6379"}'
FEAST_CORE_HOST: core

With Docker Compose the service names are resolvable hostnames by default, not just the generated container names, so this avoids the URISyntaxException problem you were having with feast_core_1 as a URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants