This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Fix printers and parsers#24
Merged
Merged
Conversation
garyb
approved these changes
Aug 2, 2017
Member
garyb
left a comment
There was a problem hiding this comment.
Looks great. We didn't need to do anything with negative numbers with unary sign in the end?
Collaborator
Author
|
I added that here https://github.com/slamdata/purescript-ejson/pull/24/files#diff-516dd23bf6e4c74ab9d4e4b7946bf694L211 But it is not important for the sql-squared parser, since it will always tokenize |
Member
|
I meant during printing actually - since there's the possibility of a negated negative number in the AST. It's only a problem when constructed by means other than the parser though I guess. |
Collaborator
Author
|
Yes, its a problem if you construct a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.