Skip to content

feat: support SLACK_CLI_APP_ICON_PATH env var for icon override #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srtaalej merged 18 commits into from
May 13, 2026
Merged

feat: support SLACK_CLI_APP_ICON_PATH env var for icon override #519

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
23afd93
fix: add assets/icon.png fallback for icon auto-detection
srtaalej Apr 27, 2026
5176129
feat: support png, jpg, jpeg, gif for icon auto-detection
srtaalej Apr 28, 2026
c9abb30
refactor: extract icon resolution to internal/icon package
srtaalej May 1, 2026
14c811f
Merge branch 'main' into ale-icon-assets-fallback
srtaalej May 1, 2026
b626cec
feat: support SLACK_CLI_APP_ICON_PATH env var for icon override
srtaalej May 1, 2026
95ded37
merge: resolve conflict with main in install_test.go
srtaalej May 1, 2026
d7e7ccd
Update internal/config/config.go
srtaalej May 4, 2026
d599052
fix: address review feedback for icon path resolution
srtaalej May 4, 2026
8df3140
Merge branch 'main' into ale-icon-assets-fallback
srtaalej May 4, 2026
87a4646
Update internal/pkg/apps/install.go
srtaalej May 5, 2026
061e54f
fix: update test to match manifest icon early-return behavior
srtaalej May 5, 2026
2778c01
Merge branch 'main' into ale-icon-env-var
srtaalej May 5, 2026
3a8c3e5
merge: integrate icon assets fallback from #509
srtaalej May 7, 2026
805fdaf
merge: resolve conflicts with main after #509 squash merge
srtaalej May 12, 2026
ac8245a
Merge branch 'main' into ale-icon-env-var
srtaalej May 12, 2026
f57be2f
Update internal/pkg/apps/install.go
srtaalej May 13, 2026
f498dc2
refactor: remove manifestIcon param from icon.ResolveIconPath
srtaalej May 13, 2026
ed4c940
Merge branch 'main' into ale-icon-env-var
srtaalej May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into ale-icon-assets-fallback
  • Loading branch information
@srtaalej
srtaalej authored May 4, 2026
commit 8df3140e3efc70b76a91eb548d6d57211dc4f2c6

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.