fix: address review feedback on icon resolution

- Move supportedExtensions to local var inside ResolveIconPath - Add test for manifest icon taking priority over magic files - Remove unused hasValidIconPath and Verify methods from SlackYaml - Remove corresponding slack_yaml_test.go (coverage lives in icon pkg) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
slackapi · srtaalej · May 11, 2026 · Apr 27, 2026 · Apr 28, 2026 · May 1, 2026
commit af619c93578bdcae4b0ebea9517b449e2fccc33f
@@ -20,13 +20,13 @@ import (
 	"github.com/spf13/afero"
 )
 
-
 func ResolveIconPath(fs afero.Fs, manifestIcon string) string {
 	if manifestIcon != "" {
 		return manifestIcon
 	}
+	supportedExtensions := []string{".png", ".jpg", ".jpeg", ".gif"}
 	for _, dir := range []string{"assets", "."} {
-		for _, ext := range SupportedExtensions {
+		for _, ext := range supportedExtensions {
 			candidate := filepath.Join(dir, "icon"+ext)
 			if _, err := fs.Stat(candidate); err == nil {
 				return candidate

@@ -32,6 +32,11 @@ func Test_ResolveIconPath(t *testing.T) {
 			manifestIcon: "custom/my-icon.png",
 			expected:     "custom/my-icon.png",
 		},
+		"manifest icon preferred over magic icon files": {
+			manifestIcon: "custom/my-icon.png",
+			files:        []string{"assets/icon.png", "icon.png"},
+			expected:     "custom/my-icon.png",
+		},
 		"assets/icon.png found": {
 			files:    []string{"assets/icon.png"},
 			expected: "assets/icon.png",

@@ -14,39 +14,8 @@
 
 package types
 
-import (
-	"os"
-	"path/filepath"
-
-	"github.com/slackapi/slack-cli/internal/icon"
-	"github.com/slackapi/slack-cli/internal/slackerror"
-	"github.com/spf13/afero"
-)
-
 type SlackYaml struct {
 	AppManifest `yaml:",inline"`
 	Icon        string `yaml:"icon"`
 	Hash        string
 }
-
-// hasValidIconPath returns false if icon path is provided but is not valid and true otherwise
-	wd, err := os.Getwd()
-	if err != nil {
-		return true
-	}
-	if sy.Icon == "" {
-		sy.Icon = icon.ResolveIconPath(afero.NewBasePathFs(fs, wd), "")
-	} else {
-		if _, err := fs.Stat(filepath.Join(wd, sy.Icon)); os.IsNotExist(err) {
-			return false
-		}
-	}
-	return true
-}
-
-// Verify checks that the app manifest meets some basic requirements
-	if !sy.hasValidIconPath(fs) {
-		return slackerror.New("Please specify a valid icon path in app manifest")
-	}
-	return nil
-}