Repository navigation
Fix #937 bolt-socket-mode establishes a connection before a SocketModeApp#start()/startAsync() method call - #939
Merged
Conversation
…ocketModeApp#start()/startAsync() method call
seratch
force-pushed
the
issue-937-socket-mode
branch
from
February 18, 2022 01:16
637cc09 to
0e288d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
============================================
- Coverage 76.49% 76.43% -0.06%
- Complexity 3651 3656 +5
============================================
Files 396 396
Lines 11030 11048 +18
Branches 1094 1095 +1
============================================
+ Hits 8437 8445 +8
- Misses 1944 1953 +9
- Partials 649 650 +1
Continue to review full report at Codecov.
|
seratch
commented
Feb 18, 2022
| public class SocketModeApp { | ||
| private boolean clientStopped = false; | ||
| private final SocketModeClient client; | ||
| private boolean clientStopped = true; |
Contributor
Author
There was a problem hiding this comment.
The default state needs to be corrected.
seratch
force-pushed
the
issue-937-socket-mode
branch
from
February 19, 2022 00:06
77c5496 to
ae09560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #937
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.