Skip to content

Add missing optional arguments#819

Merged
seratch merged 2 commits into
slackapi:mainfrom
seratch:missing-args
Aug 19, 2021
Merged

Add missing optional arguments#819
seratch merged 2 commits into
slackapi:mainfrom
seratch:missing-args

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Aug 19, 2021

While working on slackapi/python-slack-sdk#1099, I've detected a number of missing Web API arguments in this SDK.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Aug 19, 2021
@seratch seratch added this to the 1.11.0 milestone Aug 19, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2021

Codecov Report

Merging #819 (2734849) into main (05ba174) will increase coverage by 0.03%.
The diff coverage is 92.00%.

❗ Current head 2734849 differs from pull request most recent head 11721c6. Consider uploading reports for the commit 11721c6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #819      +/-   ##
============================================
+ Coverage     77.18%   77.22%   +0.03%     
  Complexity     3438     3438              
============================================
  Files           384      384              
  Lines         10296    10321      +25     
  Branches       1003     1004       +1     
============================================
+ Hits           7947     7970      +23     
- Misses         1763     1764       +1     
- Partials        586      587       +1     
Impacted Files Coverage Δ
...java/com/slack/api/methods/RequestFormBuilder.java 89.27% <92.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ba174...11721c6. Read the comment docs.

@seratch seratch merged commit cbd252f into slackapi:main Aug 19, 2021
@seratch seratch deleted the missing-args branch August 19, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant