Update link_shared event payload for the changes starting on September 1#817
Conversation
| " }\n" + | ||
| " ]\n" + | ||
| "}\n"; | ||
| LinkSharedEvent event = GsonFactory.createSnakeCase().fromJson(json, LinkSharedEvent.class); |
There was a problem hiding this comment.
FYI: This GsonFactory (for testing) detects unknown fields. If there is some, the test fails. Adding unfurlId & source made this test successful.
misscoded
left a comment
There was a problem hiding this comment.
LGTM! I'm curious to know more about the use case behind this and/or what the pain point has been up to this point that this addresses (if you happen to know).
Codecov Report
@@ Coverage Diff @@
## main #817 +/- ##
=========================================
Coverage 77.18% 77.18%
Complexity 3438 3438
=========================================
Files 384 384
Lines 10296 10297 +1
Branches 1003 1003
=========================================
+ Hits 7947 7948 +1
Misses 1763 1763
Partials 586 586
Continue to review full report at Codecov.
|
bb1aebc to
4a0a83c
Compare
srajiang
left a comment
There was a problem hiding this comment.
This looks good to me as well!
|
Hey @seratch ! Would it be okay to release this change ahead of the Sept 1 change? I'm working with a partner that would like to use the fields for some beta testing. |
|
@manucaicedo We can release it as an RC version! I will ship v1.11.0-RC1 by the end of this week. |
|
👋 @manucaicedo I just released v1.11.0-RC1 onto the Sonatype OSS repositories. The jar files will be synchronized to the Maven Central within a few hours. https://search.maven.org/artifact/com.slack.api/bolt |
This pull request updates link_shared event data class to support the new fields that are available since September 1. Refer to the changelog for more details: https://api.slack.com/changelog/2021-08-changes-to-unfurls
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.