Skip to content

Add JSON data covering all the rate limit tiers of Web APIs#815

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:web-api-rate-limits
Aug 18, 2021
Merged

Add JSON data covering all the rate limit tiers of Web APIs#815
seratch merged 1 commit into
slackapi:mainfrom
seratch:web-api-rate-limits

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Aug 17, 2021

This pull request adds a new JSON data generation for other tools. I'm planning to use this JSON output in other SDKs for implementing better support of Rate Limits.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client docs M-T: Documentation work only labels Aug 17, 2021
@seratch seratch added this to the 1.11.0 milestone Aug 17, 2021
@seratch seratch self-assigned this Aug 17, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 17, 2021

Codecov Report

Merging #815 (2bcecd1) into main (2cbd9a3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 2bcecd1 differs from pull request most recent head 6915b78. Consider uploading reports for the commit 6915b78 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #815      +/-   ##
============================================
+ Coverage     77.14%   77.20%   +0.05%     
- Complexity     3435     3439       +4     
============================================
  Files           384      384              
  Lines         10291    10296       +5     
  Branches       1002     1003       +1     
============================================
+ Hits           7939     7949      +10     
+ Misses         1766     1760       -6     
- Partials        586      587       +1
Impacted Files Coverage Δ
.../java/com/slack/api/methods/MethodsRateLimits.java 99.02% <100.00%> (+0.52%) ⬆️
...va/com/slack/api/socket_mode/SocketModeClient.java 68.42% <0.00%> (+0.65%) ⬆️
...i/socket_mode/impl/SocketModeClientJavaWSImpl.java 65.78% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbd9a3...6915b78. Read the comment docs.

@seratch seratch merged commit 05ba174 into slackapi:main Aug 18, 2021
@seratch seratch deleted the web-api-rate-limits branch August 18, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

docs M-T: Documentation work only enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch