Skip to content

Fix #98 by adding authorize function support#100

Merged
seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-98-authorize
Sep 23, 2020
Merged

Fix #98 by adding authorize function support#100
seratch merged 2 commits into
slackapi:mainfrom
seratch:issue-98-authorize

Conversation

@seratch

@seratch seratch commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

This pull request fixes #98 by adding authorize function support to App and AsyncApp. This is based on #99 branch. The essential change is this commit: 8e8248d

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 0.9.0b0 milestone Sep 22, 2020
@seratch seratch changed the title @seratch Fix #98 by adding authorize function support Fix #98 by adding authorize function support Sep 22, 2020
@codecov-commenter

codecov-commenter commented Sep 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #100 into main will increase coverage by 0.55%.
The diff coverage is 87.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   89.58%   90.14%   +0.55%     
==========================================
  Files         129      133       +4     
  Lines        3621     3775     +154     
==========================================
+ Hits         3244     3403     +159     
+ Misses        377      372       -5     
Impacted Files Coverage Δ
slack_bolt/authorization/async_authorize.py 73.07% <73.07%> (ø)
slack_bolt/authorization/authorize.py 73.07% <73.07%> (ø)
slack_bolt/app/app.py 84.74% <90.00%> (+1.32%) ⬆️
slack_bolt/app/async_app.py 91.82% <93.33%> (+0.55%) ⬆️
slack_bolt/authorization/__init__.py 100.00% <100.00%> (ø)
slack_bolt/authorization/async_authorize_args.py 100.00% <100.00%> (ø)
slack_bolt/authorization/authorization_result.py 100.00% <100.00%> (ø)
slack_bolt/authorization/authorize_args.py 100.00% <100.00%> (ø)
slack_bolt/context/base_context.py 96.77% <100.00%> (+3.22%) ⬆️
slack_bolt/logger/messages.py 85.71% <100.00%> (+2.85%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9968804...ce30c91. Read the comment docs.

@seratch

seratch commented Sep 23, 2020

Copy link
Copy Markdown
Contributor Author

Let me merge this and release a new alpha version. Please feel free to write in when you see any rooms for improvements. I will fix them by the first beta release.

@seratch seratch merged commit a3581c3 into slackapi:main Sep 23, 2020
@seratch seratch deleted the issue-98-authorize branch September 23, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add authorize function support

2 participants