Skip to content

improvement(redirects): move redirects to middleware, push to login if no session and workspace if session exists, remove telemetry consent dialog #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Aug 15, 2025
Merged

improvement(redirects): move redirects to middleware, push to login if no session and workspace if session exists, remove telemetry consent dialog #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64baf54
improvement(redirects): move redirects to middleware, push to login i…
waleedlatif1 Aug 15, 2025
a1b6ea8
remove telemetry consent dialog
waleedlatif1 Aug 15, 2025
d39d483
remove migrations
waleedlatif1 Aug 15, 2025
5682a8c
rerun migrations
waleedlatif1 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/sim/app/api/users/me/settings/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const SettingsSchema = z.object({
autoPan: z.boolean().optional(),
consoleExpandedByDefault: z.boolean().optional(),
telemetryEnabled: z.boolean().optional(),
telemetryNotifiedUser: z.boolean().optional(),
emailPreferences: z
.object({
unsubscribeAll: z.boolean().optional(),
Expand All @@ -35,7 +34,6 @@ const defaultSettings = {
autoPan: true,
consoleExpandedByDefault: true,
telemetryEnabled: true,
telemetryNotifiedUser: false,
emailPreferences: {},
}

Expand Down Expand Up @@ -69,7 +67,6 @@ export async function GET() {
autoPan: userSettings.autoPan,
consoleExpandedByDefault: userSettings.consoleExpandedByDefault,
telemetryEnabled: userSettings.telemetryEnabled,
telemetryNotifiedUser: userSettings.telemetryNotifiedUser,
emailPreferences: userSettings.emailPreferences ?? {},
},
},
Expand Down
2 changes: 0 additions & 2 deletions apps/sim/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { env } from '@/lib/env'
import { isHosted } from '@/lib/environment'
import { createLogger } from '@/lib/logs/console/logger'
import { getAssetUrl } from '@/lib/utils'
import { TelemetryConsentDialog } from '@/app/telemetry-consent-dialog'
import '@/app/globals.css'

import { ZoomPrevention } from '@/app/zoom-prevention'
Expand Down Expand Up @@ -110,7 +109,6 @@ export default function RootLayout({ children }: { children: React.ReactNode })
<body suppressHydrationWarning>
<BrandedLayout>
<ZoomPrevention />
<TelemetryConsentDialog />
{children}
{isHosted && (
<>
Expand Down
251 changes: 0 additions & 251 deletions apps/sim/app/telemetry-consent-dialog.tsx
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ...orkspaceId]/w/components/sidebar/components/settings-modal/components/privacy/privacy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export function Privacy() {
const isLoading = useGeneralStore((state) => state.isLoading)
const telemetryEnabled = useGeneralStore((state) => state.telemetryEnabled)
const setTelemetryEnabled = useGeneralStore((state) => state.setTelemetryEnabled)
const setTelemetryNotifiedUser = useGeneralStore((state) => state.setTelemetryNotifiedUser)
const loadSettings = useGeneralStore((state) => state.loadSettings)

useEffect(() => {
Expand All @@ -29,8 +28,6 @@ export function Privacy() {
setTelemetryEnabled(checked)

if (checked) {
setTelemetryNotifiedUser(true)

if (typeof window !== 'undefined') {
fetch('/api/telemetry', {
method: 'POST',
Expand Down
1 change: 1 addition & 0 deletions apps/sim/db/migrations/0073_hot_champions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE "settings" DROP COLUMN "telemetry_notified_user";
Loading