Greptile Summary

This PR cleans up the whitelabeling configuration system by removing three unused environment variables (NEXT_PUBLIC_HIDE_BRANDING, NEXT_PUBLIC_CUSTOM_FOOTER_TEXT, and NEXT_PUBLIC_SUPPORT_URL) and fixes redirect handling for privacy policy and terms pages. The changes span multiple files:

1. Environment Configuration Cleanup: Removes the unused variables from env.ts, which were defined in both the client schema and experimental runtime environment mapping but weren't actually consumed by the branding system.

2. Branding Interface Simplification: Updates the BrandConfig interface in branding.ts by removing the corresponding hideBranding, footerText, and supportUrl properties, streamlining the interface from 14 to 11 properties.

3. Next.js Redirect Logic Enhancement: Restructures the redirects function in next.config.ts to properly handle whitelabel deployments by:

   • Adding conditional redirects for /terms and /privacy pages when external URLs are configured
   • Implementing a self-hosted deployment redirect from / to /login
   • Fixing domain redirect syntax by adding the required key property to has conditions

4. Helm Configuration Updates: Removes the unused variables from both the main values.yaml, the schema validation in values.schema.json, and the example whitelabel configuration in values-whitelabeled.yaml.

The changes integrate well with the existing codebase architecture, where the getBrandConfig() function in branding.ts serves as the central point for branding configuration, and the Next.js redirects enable whitelabel deployments to point users to external privacy/terms pages when configured.

Confidence score: 4/5

• This PR is safe to merge with low risk of issues
• Score reflects clean removal of unused code and proper redirect implementation, with minor complexity in the Next.js config restructuring
• Pay close attention to next.config.ts to ensure redirect logic works correctly across different deployment scenarios

_{6 files reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}