Skip to content

fix(content): keep stored provenance consistent - #9097

Merged
icecrasher321 merged 1 commit into
stagingfrom
codex/provenance-write-consistency
Oct 16, 2026
Merged

fix(content): keep stored provenance consistent#9097
icecrasher321 merged 1 commit into
stagingfrom
codex/provenance-write-consistency

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep document and chunk tags consistent during processing, metadata edits, tag deletion, and connector metadata-only refreshes. Use the document lock across those writers and remove the redundant chunk-sequence lock.
  • Preserve content timestamps on identical table writes and export read provenance only for rows actually returned.
  • Retain validated encrypted origins across authorized file copies, member writes, and archive extraction. Keep current version snapshots and deleted-key classification consistent with recorded evidence.
  • Preserve existing admission policy, masking, budgets, and authorization. No schema changes or historical provenance reset.

Type of Change

  • Bug fix

Testing

289 PostgreSQL/Redis/storage integration checks, 93 migrated-database row-write checks, and 621 adjacent tests passed. Root tests passed all 20 workspace tasks, including 37,827 application tests and 606 script tests. Repository type-check, test-type ratchet, lint, all 60 audits, generators, and staging-aware block registry passed. Fourteen independent guard-removal variants failed for the intended regressions and were restored; the nullable connector type correction emits identical JavaScript and its 12 integration cases passed again.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 16, 2026 12:59am UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 16, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR keeps stored content and its secret-origin evidence consistent.

  • Knowledge chunks keep the document's current tags.
  • File copies and edits keep their recorded secret origins.
  • Unchanged table rows keep their content timestamp.
  • Table results carry provenance for only the rows shown.

Review was based on code and test inspection; no tests were executed.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Document or chunk writer] --> B[Lock document]
  B --> C[Read current tags]
  C --> D[Write document and chunk changes]
  D --> E[Commit together]
  F[Table query] --> G[Capture row evidence]
  G --> H[Choose rows to return]
  H --> I[Export evidence for those rows]
Loading

Reviews (1) · Last reviewed commit: "fix(content): keep stored provenance con..." · Reviewed by Greptile

@icecrasher321
icecrasher321 merged commit 7fa70e0 into staging Oct 16, 2026
53 checks passed
@icecrasher321
icecrasher321 deleted the codex/provenance-write-consistency branch October 16, 2026 01:04
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 16, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — d7cc83e5 Deployed Oct 16, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@icecrasher321