Repository navigation
fix(desktop): accept common computer calls and let input reach attached sheets - #9093
Conversation
…lls and targeted keys Mirrors the worker contract. Coordinate clicks, scrolls and drags without a windowId target the window the snapshot selected; scroll deltas default to 0; press_key with an elementId focuses that element first. Each shape was rejected before reaching the app in benchmark runs (about one call per task).
Go to Folder and out-of-process open and save panels are sheets: the app reports them as its focused window, and a panel's contents report no window at all. Input checks now treat a sheet as the window it is attached to, and a click on windowless panel content is allowed only inside the app's focused sheet.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
 [Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe PR accepts common computer calls and lets input reach sheets attached to an observed window.
Reviews (3) · Last reviewed commit: "fix(desktop): observe the focused window..." · Reviewed by Greptile |
…m targeted focus - Coordinate clicks and scrolls without a windowId use the snapshot's selected window through every input check; element targets keep their own window - press_key with an elementId sends the key only once that element holds focus - The service observes the selected window after a call without one - A scroll needs at least one delta, matching the worker contract
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
This follows #9084 and comes from two benchmark findings (MacAgentBench, Opus 5.5 through the worker loop).
Calls rejected before reaching the app. About one call per task was rejected as invalid input. This mirrors simstudioai/mothership#704, which should merge first so
contracts:syncstays in step:windowIdtarget the window the snapshot selected.press_keywith anelementIdfocuses that element first.Input refused in system panels. #9084's stricter window checks refused input in two common panels:
A sheet now counts as the window it is attached to. A click on windowless panel content is allowed only inside the app's focused sheet, and only when that sheet belongs to the observed window. Every other unconfirmed target is still refused.
Test plan