Repository navigation
fix(mothership): parse each checkpoint control request on its own and declare accepted kinds - #9086
Merged
Merged
Conversation
… declare accepted kinds The outbound receiver parsed a poll batch strictly, so one control kind this build did not know threw for the whole batch: nothing in it was answered and the worker waited out each request's timeout. Parse each request alone, answer an unknown kind 501 sim_control_unsupported and a malformed one 400, and keep running its batch-mates. Every poll now declares the kinds this build's generated contract parses, so the worker can stop sending kinds a receiver cannot handle.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe checkpoint receiver now parses each request separately instead of rejecting a whole batch.
No actionable issues were found. Tests were inspected, not run.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim_control_unsupported, a malformed one 400, a request without a readable id is dropped and logged, and its batch-mates always runaccepts: the kinds this build's generated contract parses, so the worker can stop sending kinds a receiver can't handlegenerated/sim-transport.tssynced from simstudioai/mothership#699Release order
acceptsfieldType of Change
Testing
receiver.test.ts: a batch with an unknown kind, a malformed input, and a request with no kind alongside a valid one: valid one executes, the others get 501/400, no reconnect; polls declare exactly the contract's kinds; unreadable requests are dropped without a reply (all fail before the change)control.test.tsunchanged and passingChecklist