Skip to content

chore(ci): tag production promotions with release-<sha> for rollback retention - #9061

Merged
waleedlatif1 merged 2 commits into
stagingfrom
chore/ecr-release-tags
Oct 15, 2026
Merged

chore(ci): tag production promotions with release-<sha> for rollback retention#9061
waleedlatif1 merged 2 commits into
stagingfrom
chore/ecr-release-tags

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Production promotions (latest, on main) also tag the same manifest list release-<sha> in ECR, in the same imagetools create call, so both tags resolve to one digest
  • Gives the ECR lifecycle policy a stable handle for "keep the last N production releases", so prod rollback targets no longer age out behind staging churn in the shared repos
  • release- tags trigger nothing (pipeline rules match exact deploy tags); the stale-run guard skips the release tag whenever it skips moving latest; staging/dev promotions are unchanged

Type of Change

  • Improvement

Testing

  • bash -n + shellcheck clean on promote-app-image.sh; actionlint on ci.yml reports only the pre-existing SC2086 notes
  • Repos are tag-MUTABLE, so re-runs rewriting release-<sha> to the same digest can't fail

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 15, 2026 1:29am UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 15, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable issues were found.

Summary

Production promotions now add a release-<sha> alias alongside latest.

  • Production promotions keep a release tag beside latest.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Guard{Fresh promotion?} -->|No| Skip[Skip tag writes]
  Guard -->|Yes| Verify[Verify all source images]
  Verify --> Branch{Production?}
  Branch -->|Yes| Both[Write latest and release-SHA]
  Branch -->|No| Single[Write staging or dev]
  Both --> App[Promote app last]
  Single --> App
  App --> Outputs[Record app digest and change status]
Loading

Reviews (2) · Last reviewed commit: "improvement(ci): share one promote-image..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the chore/ecr-release-tags branch from 7fefb39 to a9185b8 Compare October 15, 2026 01:24
@waleedlatif1

waleedlatif1 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 15, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5c7d838 into staging Oct 15, 2026
98 of 100 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/ecr-release-tags branch October 15, 2026 02:07
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 15, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — a9185b8e Deployed Oct 15, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1