fix(assets): update README.md#811
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Greptile Summary
This PR updates the README.md file to replace external CDN URLs with relative paths to local static assets. Specifically, it changes the Sim Studio logo and demo GIF references from vercel-storage.com URLs to local paths pointing to apps/sim/public/static/sim.png and apps/sim/public/static/demo.gif respectively.
This change improves asset reliability by reducing dependency on external CDN services and ensures that visual assets are version-controlled alongside the codebase. The modification aligns with best practices for open-source projects where assets should be self-contained within the repository rather than hosted externally. This change fits well within the monorepo structure, where the main application (apps/sim/) contains the public static assets that are now being referenced directly.
PR Description Notes:
- The PR template sections are empty and need to be filled out
- Missing description of what specific issue this addresses
- No testing information provided
- Checklist items are unchecked
Confidence score: 2/5
• This PR has moderate risk due to potential broken image links if the local files don't exist or aren't accessible in all viewing contexts
• The score reflects uncertainty about whether the referenced local files actually exist and whether relative paths will work across different platforms (GitHub, NPM, documentation sites)
• README.md needs more attention to verify that the local asset paths are correct and accessible
1 file reviewed, no comments
Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.