feat(tables): improve view and filter controls by j15z · Pull Request #6725 · simstudioai/sim

j15z · 2026-08-15T02:30:43Z

Summary

This second PR builds on #6724 and completes the table-view control changes. Users can choose which saved view is the default, Columns now uses the same menu typography and icon sizing as Sort, and filters update live after a 250 ms typing delay.

The filter builder is now AND-only and no longer shows Apply or Clear actions. Closing the filter panel or switching views flushes the latest pending edit so autosave does not lose it.

Type of Change

Testing

Focused table-view control, view-state, service, and query-hook suite: 88 tests passed across 8 files.
bun run --cwd apps/sim type-check
Repository format and lint checks passed for the stack; the final review fix also passed scoped Biome checks.
Full app run: 25,462 tests passed. Eleven unrelated tests could not create sandboxed upload files or local listening sockets; the desktop suite could not download Electron in the restricted environment.
Review focus: debounce cancellation and flush behavior, single-default cache state, and menu selection without closing the Columns popup.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not included. DOM interaction tests cover the changed menus and live-filter behavior.

Post-Deploy Monitoring & Validation

For 24 hours, monitor table-view update errors and save-error toasts after filter, column, and default-view interactions.
Validate that selecting "Set as default" leaves exactly one default view and that the chosen view opens after returning to the table.
Validate that typed filters update after the short delay, remain AND-only, and persist after closing the panel or navigating away.
Treat increased table-view update failures, duplicate defaults, or lost filter state as rollback triggers.
Owner: Tables feature maintainers. This child PR can be rolled back independently if the new controls regress while the autosave foundation remains healthy.

vercel · 2026-08-15T02:30:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 15, 2026 2:59am

cursor · 2026-08-15T02:30:54Z

PR Summary

Medium Risk
Changes filter semantics (AND-only, debounced autosave) and default-view cache logic; mistakes could lose filter edits or show stale default state, but scope is table UI and view mutations.

Overview
Completes table view controls: default view is set via per-row pin actions (replacing the "Default" badge), with optimistic cache updates so only one view stays default. Columns and Sort menus now use shared dropdown styling and stay open while toggling options (preventDefault on menu select).

Filters autosave on a 250 ms debounced onChange, are AND-only (OR saved filters normalize on load), and drop explicit Apply/Clear. Closing the filter panel or switching views calls flush() on TableFilter so pending edits persist before navigation.

^{Reviewed by Cursor Bugbot for commit 5a1ffbd. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-08-15T02:35:18Z

Greptile Summary

The PR streamlines table view, column, and filter controls, adding a set-default action and debounced filter updates.

Migrates the columns picker to the standard dropdown menu.
Adds optimistic default-view reconciliation.
Replaces explicit filter application and OR controls with automatic AND-only filtering.

Confidence Score: 4/5

The PR should not merge until opening an existing OR filter stops silently rewriting and persisting it as AND.

The new filter initialization changes supported saved predicate semantics, and the automatic debounce persists that change without user interaction.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-filter/table-filter.tsx, apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-filter/table-filter.tsx	Adds debounced automatic filtering but silently rewrites loaded OR predicates to AND and triggers persistence on mount.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx	Integrates filter flushing, set-default actions, and view persistence; its generic filter persistence makes the mount-time normalization destructive.
apps/sim/hooks/queries/tables.ts	Optimistically demotes the previous default when a promoted view response arrives, followed by authoritative invalidation.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/columns-menu/columns-menu.tsx	Migrates column visibility controls to the standard dropdown while retaining the existing toggle behavior.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx	Adds an edit-gated set-default action for non-default views.

Sequence Diagram

sequenceDiagram
  participant User
  participant Filter as TableFilter
  participant Table
  participant View as Saved view
  User->>Filter: Open saved OR filter
  Filter->>Filter: Convert every rule to AND
  Filter->>Filter: Debounce 250 ms
  Filter->>Table: onChange(AND predicate)
  Table->>View: Persist filter config

_{Reviews (1): Last reviewed commit: "feat(tables): improve view and filter co..." | Re-trigger Greptile}

greptile-apps · 2026-08-15T02:35:21Z

+    const fromFilter = predicateToFilterRules(filter).map((rule) => ({
+      ...rule,
+      logicalOperator: 'and' as const,
+    }))


OR filters are silently overwritten

When a saved view contains an any predicate, initialization changes every rule boundary to and, and the mount effect then sends that changed predicate through onChange, causing the displayed rows and persisted view to switch from OR to AND without a user edit.

Knowledge Base Used: User Tables (apps/sim/lib/table)

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5a1ffbd. Configure here.}

cursor · 2026-08-15T03:03:57Z

+            >
+              <Pin className={cn('size-3', defaultState.isDefault && 'fill-current')} />
+            </button>
+          )}


Disabled pins swallow view selection

Low Severity

The always-on pin overlay sits above the row and stays hit-testable. For the current default and for read-only members the pin is disabled, so those clicks never reach PopoverItem. The old in-row Default label selected the view; the filled pin now no-ops instead.

^{Reviewed by Cursor Bugbot for commit 5a1ffbd. Configure here.}

feat(tables): improve view and filter controls

9fb56ae

vercel Bot temporarily deployed to Preview August 15, 2026 02:30 Inactive

j15z mentioned this pull request Aug 15, 2026

feat(tables): autosave persisted default views #6724

Open

10 tasks

cursor Bot reviewed Aug 15, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

greptile-apps Bot reviewed Aug 15, 2026

View reviewed changes

fix(tables): keep menu actions open

5a1ffbd

vercel Bot temporarily deployed to Preview August 15, 2026 02:59 Inactive

cursor Bot reviewed Aug 15, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat(tables): improve view and filter controls - #6725

feat(tables): improve view and filter controls#6725
j15z wants to merge 2 commits into
feat/better-table-views-uxfrom
feat/table-view-controls

j15z commented Aug 15, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Aug 15, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Aug 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 15, 2026

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Aug 15, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Aug 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

j15z commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Screenshots/Videos

Post-Deploy Monitoring & Validation

Uh oh!

vercel Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 15, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 15, 2026

Choose a reason for hiding this comment

Disabled pins swallow view selection

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

j15z commented Aug 15, 2026 •

edited

Loading

vercel Bot commented Aug 15, 2026 •

edited

Loading

cursor Bot commented Aug 15, 2026 •

edited

Loading