Skip to content

fix(tables): auto-scroll during column drag #6722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 4 commits into from
Aug 15, 2026
Merged

fix(tables): auto-scroll during column drag #6722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68667bd
fix(tables): auto-scroll during column drag
TheodoreSpeaks Aug 15, 2026
9011512
fix(tables): keep drag targets aligned while scrolling
TheodoreSpeaks Aug 15, 2026
9c16fa6
fix(tables): preserve column targets across drag surface
TheodoreSpeaks Aug 15, 2026
3c831be
fix(tables): align workflow group drop indicators
TheodoreSpeaks Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...space/[workspaceId]/tables/[tableId]/components/table-grid/headers/column-header-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ export const ColumnHeaderMenu = React.memo(function ColumnHeaderMenu({

return (
<th
data-column-drag-target={column.key}
data-column-drag-group={column.workflowGroupId}
className={cn(
'group relative border-[var(--border)] border-r border-b bg-[var(--bg)] p-0 text-left align-middle',
stickyLeft !== undefined && 'z-[11]',
Expand Down
14 changes: 9 additions & 5 deletions ...[workspaceId]/tables/[tableId]/components/table-grid/headers/workflow-group-meta-cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ interface WorkflowGroupMetaCellProps {
size: number
startColIndex: number
columnName: string
columnKey: string
/** Underlying logical column — needed for the right-click options menu. */
column?: DisplayColumn
workflows?: WorkflowMetadata[]
Expand Down Expand Up @@ -323,6 +324,7 @@ export function WorkflowGroupMetaCell({
size,
startColIndex,
columnName,
columnKey,
column,
workflows,
isGroupSelected,
Expand Down Expand Up @@ -405,13 +407,13 @@ export function WorkflowGroupMetaCell({
}

function handleDragStart(e: React.DragEvent) {
if (readOnly || !onDragStart || !columnName) {
if (readOnly || !onDragStart) {
e.preventDefault()
return
}
didDragRef.current = true
e.dataTransfer.effectAllowed = 'move'
e.dataTransfer.setData('text/plain', columnName)
e.dataTransfer.setData('text/plain', columnKey)

const ghost = document.createElement('div')
ghost.textContent = name
Expand All @@ -422,17 +424,17 @@ export function WorkflowGroupMetaCell({
e.dataTransfer.setDragImage(ghost, ghost.offsetWidth / 2, ghost.offsetHeight / 2)
requestAnimationFrame(() => ghost.parentNode?.removeChild(ghost))

onDragStart(columnName)
onDragStart(columnKey)
}

function handleDragOver(e: React.DragEvent) {
if (!onDragOver || !columnName) return
if (!onDragOver) return
e.preventDefault()
e.dataTransfer.dropEffect = 'move'
const rect = (e.currentTarget as HTMLElement).getBoundingClientRect()
const midX = rect.left + rect.width / 2
const side = e.clientX < midX ? 'left' : 'right'
onDragOver(columnName, side)
onDragOver(columnKey, side)
}

function handleDragEnd() {
Expand All @@ -457,6 +459,8 @@ export function WorkflowGroupMetaCell({
return (
<th
colSpan={size}
data-column-drag-target={columnKey}
data-column-drag-group={groupId}
Comment thread
TheodoreSpeaks marked this conversation as resolved.
onClick={selectGroupAndOpenConfig}
onContextMenu={handleContextMenu}
draggable={isDraggable}
Expand Down
Loading
Loading